Merge pull request #6 from itziarZG/copilot/sub-pr-5
Add dialog accessibility semantics and focus management to project modals
This commit is contained in:
+15
@@ -612,6 +612,9 @@
|
|||||||
<div
|
<div
|
||||||
id="project-1-modal"
|
id="project-1-modal"
|
||||||
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-labelledby="project-1-modal-title"
|
||||||
onclick="closeModal('project-1')"
|
onclick="closeModal('project-1')"
|
||||||
>
|
>
|
||||||
<div
|
<div
|
||||||
@@ -621,6 +624,7 @@
|
|||||||
<div class="p-8 md:p-12">
|
<div class="p-8 md:p-12">
|
||||||
<div class="flex justify-between items-start mb-6">
|
<div class="flex justify-between items-start mb-6">
|
||||||
<h2
|
<h2
|
||||||
|
id="project-1-modal-title"
|
||||||
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
||||||
>
|
>
|
||||||
AI Knowledge Pipeline
|
AI Knowledge Pipeline
|
||||||
@@ -628,6 +632,7 @@
|
|||||||
<button
|
<button
|
||||||
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
||||||
onclick="closeModal('project-1')"
|
onclick="closeModal('project-1')"
|
||||||
|
aria-label="Close dialog"
|
||||||
>
|
>
|
||||||
✕
|
✕
|
||||||
</button>
|
</button>
|
||||||
@@ -718,6 +723,9 @@
|
|||||||
<div
|
<div
|
||||||
id="project-2-modal"
|
id="project-2-modal"
|
||||||
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-labelledby="project-2-modal-title"
|
||||||
onclick="closeModal('project-2')"
|
onclick="closeModal('project-2')"
|
||||||
>
|
>
|
||||||
<div
|
<div
|
||||||
@@ -727,6 +735,7 @@
|
|||||||
<div class="p-8 md:p-12">
|
<div class="p-8 md:p-12">
|
||||||
<div class="flex justify-between items-start mb-6">
|
<div class="flex justify-between items-start mb-6">
|
||||||
<h2
|
<h2
|
||||||
|
id="project-2-modal-title"
|
||||||
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
||||||
>
|
>
|
||||||
ChefGPT
|
ChefGPT
|
||||||
@@ -734,6 +743,7 @@
|
|||||||
<button
|
<button
|
||||||
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
||||||
onclick="closeModal('project-2')"
|
onclick="closeModal('project-2')"
|
||||||
|
aria-label="Close dialog"
|
||||||
>
|
>
|
||||||
✕
|
✕
|
||||||
</button>
|
</button>
|
||||||
@@ -832,6 +842,9 @@
|
|||||||
<div
|
<div
|
||||||
id="project-3-modal"
|
id="project-3-modal"
|
||||||
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
class="hidden fixed inset-0 bg-black/50 dark:bg-black/70 z-50 flex items-center justify-center p-4 backdrop-blur-sm"
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-labelledby="project-3-modal-title"
|
||||||
onclick="closeModal('project-3')"
|
onclick="closeModal('project-3')"
|
||||||
>
|
>
|
||||||
<div
|
<div
|
||||||
@@ -841,6 +854,7 @@
|
|||||||
<div class="p-8 md:p-12">
|
<div class="p-8 md:p-12">
|
||||||
<div class="flex justify-between items-start mb-6">
|
<div class="flex justify-between items-start mb-6">
|
||||||
<h2
|
<h2
|
||||||
|
id="project-3-modal-title"
|
||||||
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
class="text-3xl font-serif italic text-slate-900 dark:text-white"
|
||||||
>
|
>
|
||||||
Content Processing Automation
|
Content Processing Automation
|
||||||
@@ -848,6 +862,7 @@
|
|||||||
<button
|
<button
|
||||||
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
class="text-2xl text-slate-400 hover:text-slate-900 dark:hover:text-white transition-colors"
|
||||||
onclick="closeModal('project-3')"
|
onclick="closeModal('project-3')"
|
||||||
|
aria-label="Close dialog"
|
||||||
>
|
>
|
||||||
✕
|
✕
|
||||||
</button>
|
</button>
|
||||||
|
|||||||
+25
-2
@@ -58,20 +58,37 @@ function scrollToContact() {
|
|||||||
// Modal Management
|
// Modal Management
|
||||||
// ============================================
|
// ============================================
|
||||||
|
|
||||||
|
/** Element that had focus before a modal was opened */
|
||||||
|
let _modalPreviousFocus = null;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Open modal by project ID
|
* Open modal by project ID.
|
||||||
|
* Saves the currently focused element and moves focus into the modal.
|
||||||
* @param {string} projectId - The project identifier
|
* @param {string} projectId - The project identifier
|
||||||
*/
|
*/
|
||||||
function openModal(projectId) {
|
function openModal(projectId) {
|
||||||
const modal = document.getElementById(projectId + "-modal");
|
const modal = document.getElementById(projectId + "-modal");
|
||||||
if (modal) {
|
if (modal) {
|
||||||
|
_modalPreviousFocus = document.activeElement;
|
||||||
modal.classList.remove("hidden");
|
modal.classList.remove("hidden");
|
||||||
document.body.style.overflow = "hidden";
|
document.body.style.overflow = "hidden";
|
||||||
|
|
||||||
|
// Move focus to the first focusable element inside the modal
|
||||||
|
const focusable = modal.querySelectorAll(
|
||||||
|
'button, [href], input, select, textarea, [contenteditable="true"], [tabindex]:not([tabindex="-1"])'
|
||||||
|
);
|
||||||
|
if (focusable.length > 0) {
|
||||||
|
focusable[0].focus();
|
||||||
|
} else {
|
||||||
|
modal.setAttribute("tabindex", "-1");
|
||||||
|
modal.focus();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Close modal by project ID
|
* Close modal by project ID.
|
||||||
|
* Restores focus to the element that was focused before the modal opened.
|
||||||
* @param {string} projectId - The project identifier
|
* @param {string} projectId - The project identifier
|
||||||
*/
|
*/
|
||||||
function closeModal(projectId) {
|
function closeModal(projectId) {
|
||||||
@@ -79,6 +96,12 @@ function closeModal(projectId) {
|
|||||||
if (modal) {
|
if (modal) {
|
||||||
modal.classList.add("hidden");
|
modal.classList.add("hidden");
|
||||||
document.body.style.overflow = "auto";
|
document.body.style.overflow = "auto";
|
||||||
|
|
||||||
|
// Return focus to the element that triggered the modal
|
||||||
|
if (_modalPreviousFocus) {
|
||||||
|
_modalPreviousFocus.focus();
|
||||||
|
_modalPreviousFocus = null;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user